Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Map output #102

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

c-milocanovich
Copy link
Collaborator

  • Add support to map
  • Allow types Bubble and Choropleth
  • Click item action
  • Select and unselect point actions

image

@c-milocanovich c-milocanovich added target: major This PR is targeted for the next major release documentation Improvements or additions to documentation feature Feature implementation pull request dependencies Pull requests that update a dependency file labels Jun 7, 2024
@ncamera ncamera added target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Jun 10, 2024
Copy link
Collaborator

@ncamera ncamera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing the output! I leave some comments.

src/components/query-viewer-map/query-viewer-map.tsx Outdated Show resolved Hide resolved
Comment on lines +162 to +164
componentDidRender() {
this.renderMap();
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to have a more reactive approach to re-rendering the map?

For example, currently, if the queryTitle property is updated at runtime, the map will be destroyed and recreated just to update the title. But, if we use a Watch to execute a method that updates the title and don't execute the renderMap method, we would save a lot of proccessing and time.
The same goes for all properties when we can skip the entire map recreation by running a method.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The current behavior of the map matches what the chart output does, so in the future we'll have to do the same with the chart.

src/components/query-viewer-map/query-viewer-map.tsx Outdated Show resolved Hide resolved
@ncamera ncamera changed the title enabled query viewer map Add support for Map output Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation feature Feature implementation pull request target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants