Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[showcase][tabular-grid] Include all cases #460

Merged
merged 50 commits into from
Jan 30, 2025
Merged

[showcase][tabular-grid] Include all cases #460

merged 50 commits into from
Jan 30, 2025

Conversation

bsastregx
Copy link
Collaborator

Changes in this PR:

Include Tabular Grid cases in the new Angular showcase.

@bsastregx
[showcase][tabular-grid] Init showcase component + first case
e4793fa
@bsastregx
[shocase][tabular-grid] Include remaining shells
4e57571
@bsastregx
[showcase][tabular-grid] Add "With Rowset" case
73638d4
@bsastregx
[showcase][tabular-grid] Add "Selection: single + keyboard: focus" …
2173dbc 
…case
@bsastregx
[showcase][tabular-grid] Add "selection: single + keyboard: select"…
9ad5772 
… case
@bsastregx
[showcase][tabular-grid] Add "selection: multiple + keyboard: focus…
250d213 
…" case
@bsastregx
[showcase][tabular-grid] Add "selection: multiple + keyboard: selec…
07d5d77 
…t" case
@bsastregx
[showcase][tabular-grid] Add "row mark + keyboard: select" case
313279f
@bsastregx
[showcase][tabular-grid] Add "row mark + keyboard: focus" case
dd6426c
@bsastregx
[showcase][tabular-grid] Add "row reorder (dragging)" case
4408bd5
@bsastregx
[showcase][tabular-grid] Add "Row action" case
08538ae
@bsastregx
[showcase][tabular-grid] Add "tree grid" case
280d41c
@bsastregx
[showcase][tabular-grid] Add all "helpers" cases
bedce2f
@bsastregx
[showcase][tabular-grid] Add descriptions
2cdff5c
@bsastregx
[showcase][tabular-grid] Add missing title number
0485046
@bsastregx
[showcase][components] Add a common/html.ts
d3b298e 
- Add a common `html.ts` file to print common strings on the components showcase pages.
@bsastregx
[showcase][tabular-grid] Split helper cases
15617ee
@bsastregx
[showcase][components] Add some common classes
7643102
@bsastregx bsastregx added documentation Improvements or additions to documentation enhancement New feature or request showcase Work related to improving the showcase of the design systems labels Jan 24, 2025
@bsastregx bsastregx requested a review from ncamera January 24, 2025 13:28
@bsastregx
Copy link
Collaborator Author

bsastregx commented Jan 24, 2025 •
edited
Loading

@ncamera a note about this PR:

ncamera
ncamera requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@ncamera ncamera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

packages/showcase/src/app/components/tabular-grid/metadata.ts Outdated Show resolved Hide resolved
packages/showcase/src/app/components/tabular-grid/metadata.ts Outdated Show resolved Hide resolved
packages/showcase/src/app/components/tabular-grid/metadata.ts Outdated Show resolved Hide resolved
packages/showcase/src/app/components/tabular-grid/metadata.ts Outdated Show resolved Hide resolved
packages/showcase/src/app/components/tabular-grid/metadata.ts Outdated Show resolved Hide resolved
packages/showcase/src/app/components/tabular-grid/tabular-grid.component.html Outdated Show resolved Hide resolved
packages/showcase/src/app/components/tabular-grid/tabular-grid.component.html Outdated Show resolved Hide resolved
packages/showcase/src/app/components/tabular-grid/tabular-grid.component.scss Outdated Show resolved Hide resolved
packages/showcase/src/user-controls/code-snippet/code-snippet.scss Outdated Show resolved Hide resolved
@bsastregx
[showcase][tabular-grid] Update fancy lines for alignment
5e4d401 
- Update the fancy lines for "alignment" cases that help visualize the alignment in each case. This feature is hidden at the time of writting, and will be visible when the "fancy" mode feature is implemented.
@bsastregx
[showcase][tabular-grid] Fix typo
326c98e
@bsastregx
Merge branch 'main' into showcase/update/tabular-grid
5d90b25
@bsastregx
Merge branch 'main' into showcase/update/tabular-grid
cba503e
@bsastregx
[showcase][tabular-grid] Update metadata attributes with properties
a44e66c
bsastregx and others added 26 commits January 24, 2025 20:57
@bsastregx
[showcase][tabular-grid] Update metadata.ts css class with constants
f59b873
@bsastregx
[showcase][tabular-grid] Move css constants to component.ts
ecc648d
@bsastregx
[showcase][tabular-grid] Use css constants on html file
a67ee97
@bsastregx
[showcase][tabular-grid] Update "Row action" case
0a58617 
Add missing info in metadata
@bsastregx
[showcase][tabular-grid] Booleanize boolean values
16d3ff4
@bsastregx
[showcase][tabular-grid] Make button and type="button"
defb093
@bsastregx
[showcase][tabular-grid] update attributes to properties
a11c2c1
@bsastregx
[showcase][tabular-grid] Apply little suggestions from PR Review
1222246
@bsastregx
[showcase][tabular-grid] Display all panel cases
5038202
@bsastregx
[tabular-grid] Remove [language]="'ts'"
80b9b51
@bsastregx
[showcase][tabular-grid] make all rowId properties
7101ad8
@bsastregx
[showcase][tabular-grid] Fix: Make rowid lowercase
b3ad8a6
@bsastregx
[showcase][tabular-grid] Fix ch-tabular-grid-rowset indentation
de94fea
@bsastregx
[showcase][tabular-grid] Move css classes to external ts file
6d06ac1
@bsastregx
[showcase][tabular-grid] Test and fix 1 and 2 markup code
2005c00
@bsastregx
[showcase][tabular-grid] Fix selectionSingleKeyboardFocus markup …
a0f50d2 
…code
@bsastregx
[showcase][tabular-grid] Test and fix markup code case number 3
0394256
@bsastregx
[showcase][tabular-grid] Test and fix markup code case number 4
52f41b3
@bsastregx
[showcase][tabular-grid] Test and fix markup code case number 5
309b35c
@bsastregx
[showcase][tabular-grid] Test and fix markup code case number 6
fb3f176
@bsastregx
[showcase][tabular-grid] Test and fix markup code case number 7
391cf8e
@bsastregx
[showcase][tabular-grid] Test and fix markup code case number 8
12b494f
@bsastregx
[showcase][tabular-grid] Test and fix markup code case number 10
950e557
@bsastregx
[showcase][tabular-grid] Include scrollable class
e3a8f67
@bsastregx
Update package-lock.json
92ba5ef
@bsastregx
[showcase][tabular-grid] Display all cases on the filter
8aae6a5
@bsastregx bsastregx requested a review from ncamera January 30, 2025 04:47
ncamera
ncamera approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@ncamera ncamera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 👍 👍

@bsastregx bsastregx merged commit d17e0ff into main Jan 30, 2025
6 checks passed
@bsastregx bsastregx deleted the showcase/update/tabular-grid branch January 30, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncamera ncamera ncamera approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request showcase Work related to improving the showcase of the design systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsastregx @ncamera