Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update snapshot labels #900

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

anaiberta
Copy link
Contributor

Use the 'beta' and 'preview' instead of 'trunk' and 'stable' to identify the package version, following SemVer guidelines.

Issue: 201475

Use the 'beta' and 'preview' instead of 'trunk' and 'stable' to identify the package version, following SemVer guidelines.

Issue: 201475
No need to increase the number to resolve the precedence.
@anaiberta
Copy link
Contributor Author

I understand that this PR affects the integration with AndroidFlexibleClient. We need to coordinate on this. Can you help me with that, @jotapeg?

@jotapeg
Copy link
Contributor

jotapeg commented Sep 13, 2024

I understand that this PR affects the integration with AndroidFlexibleClient. We need to coordinate on this. Can you help me with that, @jotapeg?

Sure. The standard Java classes version is not automatically updated on the Android Flexible Client, and we are currently pointing to 4.7-stable.20240611142121-SNAPSHOT and 104.7-trunk.20240626135521-SNAPSHOT on master and beta, respectively. So I guess there will be no problem as long as those versions exist while building the new ones (preview and beta suffixes). After this is done, I can change both references in AndroidFlexibleClient and genexus-suite-legacy repositories. Is that okay? Or am I missing something?

@anaiberta
Copy link
Contributor Author

@iroqueta until now i have ths PR as a Draft to avoid changing BETA version. Can you do the review now? I think we can do the versioning change now.

@jechague
Copy link
Member

jechague commented Dec 6, 2024

The changes look OK to me (not approving the PR since that would trigger the beta bot by marking this PR as ready for review)

@anaiberta anaiberta marked this pull request as ready for review December 6, 2024 14:30
@anaiberta anaiberta requested a review from a team as a code owner December 6, 2024 14:30
@genexusbot
Copy link
Collaborator

Cherry pick to beta success

@anaiberta anaiberta merged commit 5ca968c into master Dec 6, 2024
10 checks passed
@anaiberta anaiberta deleted the feat/update-snapshot-labels branch December 6, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants