GamCryptography EO migration to GamUtils EO on Github #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iroqueta
reviewed
Jul 29, 2024
gamutils/src/test/java/com/genexus/gam/utils/test/resources/CryptographicHash.java
Outdated
Show resolved
Hide resolved
iroqueta
reviewed
Jul 29, 2024
| public String ComputeHash(String data) { | ||
| try { | ||
| if (alg == null) alg = MessageDigest.getInstance("SHA-512"); | ||
| alg.update(data.getBytes(CharEncoding.UTF_8)); |
There was a problem hiding this comment.
It's better to use StandardCharsets.UTF_8 instead of CharEncoding.UTF_8
Using StandardCharsets UnsupportedEncodingException catch is unnecessary.
There was a problem hiding this comment.
I would prefer to not change that, it is the old implementation copied into resources to check for backwards compatibility.
iroqueta
reviewed
Jul 29, 2024
gamutils/src/test/java/com/genexus/gam/utils/test/CertificateTest.java
Outdated
Show resolved
Hide resolved
iroqueta
reviewed
Jul 29, 2024
gamutils/src/test/java/com/genexus/gam/utils/test/CertificateTest.java
Outdated
Show resolved
Hide resolved
iroqueta
reviewed
Jul 29, 2024
iroqueta
reviewed
Jul 29, 2024
gamutils/src/main/java/com/genexus/gam/utils/CertificateUtil.java
Outdated
Show resolved
Hide resolved
BETA RESET - Cherry pick to beta failed, 2 conflicted files in commit 2d150fc
|
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GamCryptography EO migration from svn to GamUtils EO on Github