Added mmap support for both color benchmark variants #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Idb4fc32d4691795bba623d579153459d79a1f2f6
mattsinc
requested changes
Mar 24, 2024
There was a problem hiding this comment.
I thought you were going to push all of the other Pannotia benchmarks publicly at once to avoid needing to review them one by one? In any event, since it's here, let's just review and commit it!
One thing: I believe the only difference between maxmin's and max's changes are the max() call? If so, maybe we should make a header file for all of this to avoid almost the same code twice?
| @@ -129,7 +350,7 @@ int main(int argc, char **argv) | |||
| int *color_d; | |||
| int *node_value_d; | |||
| int *stop_d; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Iacc15529befcf5f1541b0209dc32eebf689f2725
Adds mmap support to both color benchmark variants