-
-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MySQL 8.4 #549
base: master
Are you sure you want to change the base?
Support MySQL 8.4 #549
Conversation
@@ -61,7 +73,7 @@ | |||
with_items: "{{ mysql_root_hosts.stdout_lines|default([]) }}" | |||
when: > | |||
((mysql_install_packages | bool) or mysql_root_password_update) | |||
and ('5.7.' not in mysql_cli_version.stdout and '8.0.' not in mysql_cli_version.stdout) | |||
and ('5.7.' not in mysql_cli_version.stdout and '8.' not in mysql_cli_version.stdout) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only downside to this change is maybe the comparison would break if there were a version like 5.8.0
, that version would be identified as 8.
... trying to think of a better way to narrow it. Maybe add in something to trim off the first two digits, and compare that to 8.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this solution, but as far as I know, version 5.8 doesn't exist. However, everything works fine on version >= 5.7. If you want, I can change the version definition using trim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using trim would be ever so slightly more future proof. It feels more correct to me.
Hi Guys, thanks for your awsome work. i would appreciate if this got released in near future :) I´ve successully tested with mysql 8.4 and ubuntu 24.04. Let me know if i can assist. Cheers Tim |
I've changed the method for resetting the root user password in MySQL 8+ since
mysql_native_password
is no longer enabled by default. Link https://dev.mysql.com/doc/refman/8.4/en/native-pluggable-authentication.htmlNow, versions of MySQL 8.* are correctly identified.