Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug/194 - Raster identification tool #212

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Fix bug/194 - Raster identification tool #212

merged 5 commits into from
Jan 28, 2025

Conversation

zacdezgeo
Copy link
Collaborator

What I Changed

  • Identify Tool Not Working on Earth Engine Raster Layers #194 was not returning any results from the underlying EarthEngine dataset because of a mismatch between the point's projection and the underlying dataset.
  • The PR adds handling of the projection.
  • I also added some unit tests where we mock Map.getScale to a similar value from running within QGIS.

How to test it

  • Run the identify tool on a raster such as the DEM from the README example
  • Run unit tests (or check out our CI)

Other notes

Screenshare.-.2025-01-21.11_52_17.AM.mp4

@zacdezgeo zacdezgeo requested review from gena and alukach January 21, 2025 19:54
@zacdezgeo zacdezgeo self-assigned this Jan 21, 2025
@zacdezgeo zacdezgeo merged commit 29863f4 into master Jan 28, 2025
4 checks passed
@zacdezgeo zacdezgeo deleted the feat/vector-identify branch January 28, 2025 19:04
alukach
alukach reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@alukach alukach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alukach alukach alukach left review comments

@gena gena Awaiting requested review from gena

Assignees

@zacdezgeo zacdezgeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identify Tool Not Working on Earth Engine Raster Layers
2 participants
@zacdezgeo @alukach