geanypg: Update to Scintilla 5.1.5 SCI_GETSELTEXT change #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should not use send message directly, should use |
Good point, then it doesn't need the API bump change. But I think we should actually do ABI bump because the previous version won't work correctly, what do you think? |
Well thats part of Geany, and discussions elsewhere, not this PR, and as @kugel- pointed out elsewhere that won't help if the plugin gets re-compiled, but its better than nothing. |
|
LGTM |
kugel-
approved these changes
Aug 27, 2022
The SCI_GETSELTEXT method of Scintilla changed so it returns a smaller number of bytes than before. Instead, use the sci_ wrappers which are independent of Geany version and should behave the same way regardless of Geany version.
|
I'm merging this as I think the patch is OK - it should be the last piece of the Scintilla 5.1.5 aftermath. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Scintilla release notes here
https://www.scintilla.org/ScintillaHistory.html
and geany/geany#3095