Set timeout to None to avoid timeout errors
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-1991
changed the title
timout to None to avoid timeout errorstimeout to None to avoid timeout errors
pdurbin
approved these changes
May 16, 2024
|
@pdurbin thanks! Will deliver the tests soon and then we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In issue #187, it was noted that the current implementation using
httpxthrows an exception when a timeout exceeds 5 seconds. This can be problematic when uploading bulk data to Dataverse, as server-side processing times can cause delays and trigger the exception. This pull request sets thetimeoutparameter toNone, which is equivalent to an unlimited timeout. We may need to consider whether this approach is reasonable or if a specific time limit would be more appropriate.TLDR
timeouttoNonefor no timeoutTasks
Closes #187