Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON folder folding in Firefox #1719

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix JSON folder folding in Firefox #1719

merged 1 commit into from
Feb 15, 2024

Conversation

GoForceX
Copy link
Contributor

Close #1707

Looks like that using display: contents; in summary may cause some weird effect.

whatwg/html#1839 (comment)

This PR:

  1. remove display: contents;
  2. add list-style: none; for hiding the default disclosure triangle
  3. add display: inline; to ensure consistent layout

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024

CLA assistant check
All committers have signed the CLA.

@a3957273
Copy link
Member

Tested this out and definitely seems to fix the issue, thanks for the contribution! 👍

@a3957273 a3957273 merged commit ba82941 into gchq:master Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder folding is not working in Firefox
3 participants