Bai 1456 fix model and datacard tab loading

[IR96334]

No description provided.

[ARADDCC012]

Nesting additional conditional logic within a ternary is generally considered something to avoid, simply for the fact that it becomes difficult to read.

In this case it's unnecessary to include the dataCard && condition due to the fact that if the first check (which includes the condition !dataCard) returns false, then dataCard must be truthy (i.e. not undefined in this case).

Also, and this is my fault, the loading condition for data cards is simpler than models. That's my mistake for not clarifying in the ticket.

In short, you can do the following:

      {!dataCard || isDataCardLoading ? (
        <Loading />
      ) : (
        <PageWithTabs
          title={dataCard.name}
          subheading={`ID: ${dataCard.id}`}
          tabs={tabs}
          requiredUrlParams={{ dataCardId: dataCard.id }}
          titleToCopy={dataCard.name}
          subheadingToCopy={dataCard.id}
        />
      )}

[IR96334]

Yeah, makes sense as the and operator is doing the same thing as my ternary operator so its redundant.

[ARADDCC012]

Same here, we don't need this second condition to check the model exists. If it fails the first check then we know the model exists.

      {!model || isModelLoading || isCurrentUserLoading || isUiConfigLoading ? (
        <Loading />
      ) : (
        <PageWithTabs
          title={model.name}
          subheading={`ID: ${model.id}`}
          additionalInfo={model.description}
          tabs={tabs}
          displayActionButton={model.card !== undefined}
          actionButtonTitle='Request access'
          actionButtonOnClick={requestAccess}
          requiredUrlParams={{ modelId: model.id }}
          titleToCopy={model.name}
          subheadingToCopy={model.id}
          sourceModelId={model.settings.mirror?.sourceModelId}
        />
      )}

[IR96334]

Fixed

[ARADDCC012]

These two hooks aren't needed for data cards. Apologies for the ticket being unclear.

[IR96334]

Fixed