fix removal of inner_polygons from outer_polygons #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 28 28
Lines 2505 2505
=======================================
Hits 2453 2453
Misses 52 52 ☔ View full report in Codecov by Sentry. |
|
Thank you @AtelierLibre! Closes #1098 |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #1098. As described by @orrsim, the difference in the inner loop was referring back to the original
outer_polygonrather than the result of any previous differenceouter_polygon_diff.With this fix,
ox.features_from_point( (60.4436,10.2364), tags = {'natural' : 'water'}, dist = 100 )returns Fjorda with the islands removed.
@orrsim, thanks for pointing this out and also for identifying the bug.