Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

take two: relax ErrJournalNotFound only when writing recovered ACKs #358

Merged
merged 4 commits into from
Dec 13, 2023

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    38e5440 View commit details
    Browse the repository at this point in the history
  2. broker/client: make ErrJournalNotFound a terminal error

    Currently, AppendService will loop forever waiting for an appended
    journal to spring (back) into existence if it's not found.
    
    Instead, immediately fail the AsyncAppend and all of its dependents.
    
    This is desirable because journal deletions are often asynchronous and
    race deployed shards, and there's not much that can be done aside from
    failing and handling the error at a higher level.
    jgraettinger committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    78bcf23 View commit details
    Browse the repository at this point in the history
  3. broker/client: Appender retries on insufficient journal brokers

    This happens when a journal is new and the topology is converging.
    It shouldn't result in a terminal Append failure.
    jgraettinger committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5c58f6d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. consumer: when writing recovered ACKs, allow for missing journals

    It's not uncommon for recovered ACKs to contain journals which have
    since been deleted. When this happens, log a warning and otherwise
    discard the ACK intent.
    
    Do this only for recovered intents: writen ACKs of the current session
    must still exist.
    jgraettinger committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    71f54d0 View commit details
    Browse the repository at this point in the history