fix: Azure fragment store with multiple tenants #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I knew that the service credentials would be scoped to tenant IDs, but I did not realize that the `service.Client`s and `UserDelegationCredential`s would also be tenant-scoped. This was causing problems where the credentials of whatever tenant was first seen would be used to sign _all_ `SignGet` URLs, resulting in signature mismatch errors when the blob was owned by a different tenant. This updates the cache logic to keep track of both the service clients and the user delegation credentials by tenant ID, which should solve the problem.
jgraettinger
requested changes
Dec 7, 2023
jshearer
force-pushed
the
jshearer/fix_azure_storage_multiple_tenants
branch
from
f55be63
to
b897637
Compare
jgraettinger
reviewed
Dec 8, 2023
jshearer
force-pushed
the
jshearer/fix_azure_storage_multiple_tenants
branch
from
278c802
to
800c8cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I knew that the service credentials would be scoped to tenant IDs, but I did not realize that the
service.Clients andUserDelegationCredentials would also be tenant-scoped. This was causing problems where the credentials of whatever tenant was first seen would be used to sign allSignGetURLs, resulting in signature mismatch errors when the blob was owned by a different tenant.This updates the cache logic to keep track of both the service clients and the user delegation credentials by tenant ID, which should solve the problem.
This change is