-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go mod: update grpc module to latest 1.59.0 #352
Conversation
4d3782e
to
d34c1d3
Compare
I'm definitely in favor of updating, but this first needs to be fully reconciled with #335 I don't have a handle on the API changes for gRPC balancers or the implications of updating, and we would need to verify all that first. |
Changelog from 1.40.0 to 1.59.0 with notable behaviour changes:
The changes introduced in 1.58.0 are addressed in this pull-request. |
701bd63
to
47d2311
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9ded86c
to
a6a1e71
Compare
See grpc/grpc-go#6481, specifically weightedtarget_test.go as an example of how tests need to be migrated now that UpdateSubConnState is deprecated. I have followed the same example in our dispatcher_test.go
a6a1e71
to
f034b5c
Compare
See grpc/grpc-go#645
This change is