Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RenderingIface_TEST's RegisterEngine test to only load the specified engine (backport #1098) #1099

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 14, 2025

🦟 Bug fix

Fixes #1072

Summary

The RenderingIface_TEST tried to load the ogre (ogre 1.x) plugin even when GZ_ENGINE_TO_TEST set to ogre2. This PR updates the test to ensure that the specified engine is used in the test. While doing this I found and fixed a bug when unregistering a default engine by name (e.g. ogre2).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #1098 done by [Mergify](https://mergify.com).

@iche033 iche033 merged commit 75b6aa3 into gz-rendering8 Jan 14, 2025
9 of 10 checks passed
@iche033 iche033 deleted the mergify/bp/gz-rendering8/pr-1098 branch January 14, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant