-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorts and adds more projects using Gazebo. #570
base: master
Are you sure you want to change the base?
Conversation
@@ -4,27 +4,31 @@ This is an incomplete list of projects that use (modern) Gazebo. It includes | |||
plugins, examples, ROS integrations, etc. If you'd like to add your project, | |||
please open a pull request by clicking on the "Edit on Github" link. | |||
|
|||
## Gazebo Plugins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep the "Gazebo Plugins" section? I was hoping it would encourage people to add items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sorta fits into a grey area IMO, the difference from tightly coupled integrations with transport vs "plugin" seems that it might be an overly specific delineation for very similar end user experience? Considering it had no entries (yet)... I think at least showing how to start a project with a template to me is a meaningfully delineable item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't opposed to the new "Gazebo tools for Integration" subsection. Just asking if we should still keep the "Gazebo Plugins" subsection as well, even though it's empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally vote to only do it by project and not delineate the way or method, but let people follow the links to see the integration method instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would disagree. More structure (to a reasonable degree) would make it easier to find things. The section below is specifically for Gazebo and ROS 2 integration. If the project is a standalone plugin that implements a specific functionality, e.g. model interaction forces between diple magnets (https://github.com/vustormlab/storm_gazebo_ros_magnet from my grad school days 😉 ), I think it would be nice to highlight it in a separate section since users might be able to use it immediately in their own projects.
Signed-off-by: Benjamin Perseghetti <[email protected]>
2f6be13
to
25e6276
Compare
Summary
Fairly sorts the projects in alphabetical order and highlights tools used to help create new integrations.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.