Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy and cython to setup requirements #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

assafmus
Copy link

I added the numpy and cython to setup.py requirements.
This enables pip installing this repo without having to manually install numpy and cython beforehand.

I'm still getting this error:
image

I'm not sure if this change is 100% ready but it works for me and the test pass.

@lig
Copy link

lig commented Aug 31, 2022

@gatagat what do you think about this one?

@gatagat
Copy link
Owner

gatagat commented Sep 3, 2022

I don't think this is solving the issue. The install_requires setting is for runtime dependencies, not setup time dependencies. So adding cython/numpy to install_requires will not ensure that it is installed when setup.py runs and these packages are needed.

There are three possibilities:

  1. Avoid requiring those packages at setup time by pre-generating and distributing the cythonized pyx file.
  2. Avoid requiring the setup itself as per PEP517/518 + e.g. flit.
  3. Publish wheels for major systems making it even simpler for users (no compiler required).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants