Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow QAPage to set URL for author #1479

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Conversation

amadeusj5
Copy link
Contributor

@amadeusj5 amadeusj5 commented Aug 13, 2024

Description of Change(s):


Allow QAPage to set author URL if exists. Right now the current behavior would only set the name for the author but in order to improve the SEO we allow now setting the author with name and url if object is passed on (or you can just set the author as a string and it will set the proper structure with the name only) by reusing the setAuthor function logic.


To help get PR's merged faster, the following is required:

[x] Updated the documentation
[x] Unit/Cypress test covering all cases

Please link to relevant Google Docs or schema.org docs for what you are adding so we can review.
https://developers.google.com/search/docs/appearance/structured-data/qapage

Please have a read of the Contributing Guide for full details.

https://github.com/garmeeh/next-seo/blob/master/CONTRIBUTING.md

Before

image

After

image

@amadeusj5
Copy link
Contributor Author

Hi @garmeeh, can you check this out please? 🙏🏽

@amadeusj5
Copy link
Contributor Author

Hi @garmeeh any change you can take a look at this? it's a minor change but it will be really helpful for me 🙏🏽

@garmeeh
Copy link
Owner

garmeeh commented Aug 26, 2024

Hey @amadeusj5 I'll get this released for you this week.

Could you take a look at the failing tests?

@amadeusj5
Copy link
Contributor Author

Hi @garmeeh, test updated. Thanks in advance 🙏🏽

@garmeeh
Copy link
Owner

garmeeh commented Aug 30, 2024

Amazing. I've set the tests to run. I will release over the weekend then.

@garmeeh garmeeh merged commit 1afb6e6 into garmeeh:master Sep 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants