Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove outdated external access rule #876

Merged
merged 2 commits into from
Oct 24, 2024
Merged

remove outdated external access rule #876

merged 2 commits into from
Oct 24, 2024

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Oct 23, 2024 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement
/platform gcp

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Remove redundant firewall rule `*-allow-external-access` that allowed traffic from all 0

@kon-angelo
Copy link
Contributor Author

/test

@gardener-robot gardener-robot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure labels Oct 23, 2024
@testmachinery
Copy link

testmachinery bot commented Oct 23, 2024 •
edited
Loading

Testrun: e2e-r26sc
Workflow: e2e-r26sc-wf
Phase: Failed

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Failed    | 8m48s    |
| infrastructure-test | infra-flow-test     | Failed    | 9m28s    |
| infrastructure-test | infra-migrate-test  | Failed    | 8m52s    |
| bastion-test        | bastion-test        | Succeeded | 9m48s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 23, 2024
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 23, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Oct 23, 2024 •
edited
Loading

Testrun: e2e-mlzp7
Workflow: e2e-mlzp7-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 8m43s    |
| infrastructure-test | infra-flow-test     | Succeeded | 7m57s    |
| infrastructure-test | infra-migrate-test  | Succeeded | 8m10s    |
| bastion-test        | bastion-test        | Succeeded | 9m34s    |
+---------------------+---------------------+-----------+----------+

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@kon-angelo kon-angelo marked this pull request as ready for review October 23, 2024 12:27
@kon-angelo kon-angelo requested review from a team as code owners October 23, 2024 12:27
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 23, 2024
@kon-angelo
Copy link
Contributor Author

/test

@testmachinery
Copy link

testmachinery bot commented Oct 23, 2024 •
edited
Loading

Testrun: e2e-wjshc
Workflow: e2e-wjshc-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| bastion-test        | bastion-test        | Succeeded | 9m52s    |
| infrastructure-test | infrastructure-test | Succeeded | 8m38s    |
| infrastructure-test | infra-flow-test     | Succeeded | 8m35s    |
| infrastructure-test | infra-migrate-test  | Succeeded | 8m0s     |
+---------------------+---------------------+-----------+----------+

@kon-angelo
Copy link
Contributor Author

/invite @ScheererJ

@kon-angelo
Copy link
Contributor Author

/invite @DockToFuture

ScheererJ
ScheererJ approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

As discussed offline, I think this should work well without this rule.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 23, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 23, 2024
@kon-angelo kon-angelo merged commit 6688d01 into gardener:master Oct 24, 2024
14 checks passed
@kon-angelo kon-angelo deleted the remove-outdated-rule branch October 24, 2024 08:20
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

@DockToFuture DockToFuture Awaiting requested review from DockToFuture

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kon-angelo @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot