Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds etcd-cluster-size pod label and fixes handling of simultaneous changes to Peer TLS, Replicas and Pod labels #882

Closed
wants to merge 6 commits into from
Closed

Adds etcd-cluster-size pod label and fixes handling of simultaneous changes to Peer TLS, Replicas and Pod labels #882

wants to merge 6 commits into from

Conversation

unmarshall
Copy link
Contributor

@unmarshall unmarshall commented Sep 25, 2024 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind bug

Which issue(s) this PR fixes:
Fixes #881, #877

Special notes for your reviewer:
/cc @ashwani2k @shreyas-s-rao @ishan16696
I will update the test cases as a comment in the PR.

Release note:

* A new pod label druid.gardener.cloud/etcd-cluster-size
* Fixed the ready condition for the Etcd resource
* Fixes for handling simultaneous change of pod template labels, label-selector, replicas and Peer TLS. Since StatefulSet does not allow update of pod template labels and label-selector this will result in a downtime for single-node etcd clusters and also when increasing the replicas for an existing etcd cluster from 1 to N (n being an odd number).

@unmarshall unmarshall requested a review from a team as a code owner September 25, 2024 06:03
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug labels Sep 25, 2024
@unmarshall unmarshall marked this pull request as draft September 25, 2024 06:03
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 25, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 25, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 26, 2024
@unmarshall unmarshall marked this pull request as ready for review September 26, 2024 12:08
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 26, 2024
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind

@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

1 similar comment
@unmarshall
Copy link
Contributor Author

/test pull-etcd-druid-e2e-kind-nondistroless-etcd

@unmarshall
Copy link
Contributor Author

/close in favor of #883

@unmarshall unmarshall closed this Oct 1, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 1, 2024
@unmarshall unmarshall deleted the bugfixes branch December 12, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
4 participants
@unmarshall @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot