Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pre-commit CI updates #557

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix pre-commit CI updates #557

merged 3 commits into from
Nov 25, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Nov 25, 2024

  1. We were getting permission errors when pushing a branch using my account PAT. I added a GitHub App to the Gaphor org, and this PR makes use of it to make the PR updates instead.
  2. Updates Linux runners to Ubuntu 24.04
  3. Enables network access for Immutable Actions per the breaking change announcement)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw requested a review from amolenaar November 25, 2024 02:31
amolenaar
amolenaar approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update 👍

@amolenaar amolenaar merged commit 2895083 into main Nov 25, 2024
12 checks passed
@amolenaar amolenaar deleted the ci-updates branch November 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolenaar amolenaar amolenaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyeaw @amolenaar