fix: revert removal of defs, add instanceId suffix to ensure uniquene…

[Arukuen]

…ss of IDs

fixes #3265

[github-actions]

🤖 Pull request artifacts

file	commit
pr3303-stackable-3303-merge.zip	7b7ac5a

[github-actions]

Try this Pull Request in the WordPress playground: https://playground.wordpress.net/?mode=seamless#{"landingPage":"/wp-admin/post-new.php?post_type=page","preferredVersions":{"php":"latest","wp":"latest"},"steps":[{"step":"login","username":"admin","password":"password"},{"step":"installPlugin","pluginZipFile":{"resource":"url","url":"https://raw.githubusercontent.com/gambitph/Stackable/artifacts/pr3303-stackable-3303-merge.zip"}}]}

[bfintal]

useInstanceId just counts the instances of the object in the editor. So there is a large chance that this can conflict when used across the site - e.g. the first icon used in a page is always instance "#1"

Instead of doing useInstanceId, generate a random number to append instead directly inside cleanSvgString

[andeng1106]

@Arukuen @bfintal When uploading this SVG, it still doesn't display both on frontend and editor. The SVG icon is from the user that causes the issue to be reopened.

Screen.Recording.2024-09-23.at.2.mp4

[bfintal]

The SVG pointed out seems to have an image embedded inside it. I believe we will not support this one (and WP might be stripping this out as well)