Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editing/adding global colors when blocks are present is slow #3299

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

bfintal
Copy link
Contributor

@bfintal bfintal commented Aug 21, 2024

Adjustments:

  • When adding global colors, fallback colors will no longer be updated
  • When using global colors, fallback colors will no longer be added

Here's what this adjustment looks like:

- color: var(--stk-global-color-1234, #ff00ff);
+ color: var(--stk-global-color-1234);

@bfintal bfintal self-assigned this Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

🤖 Pull request artifacts

file commit
pr3299-stackable-3299-merge.zip 564a38e

github-actions bot added a commit that referenced this pull request Aug 21, 2024
@andeng1106
Copy link

@bfintal Text Color name is no longer showing when selecting existing global text colors in the palette. It's showing the var() instead:

Screen.Recording.2024-08-21.at.3.mp4

github-actions bot added a commit that referenced this pull request Sep 23, 2024
@bfintal bfintal merged commit cc36860 into develop Sep 23, 2024
1 of 6 checks passed
@bfintal bfintal deleted the fix/slow-global-colors branch September 23, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants