-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuration for community content #169
Conversation
- Move sources (code) to a `source` folder - Move metadata, resources, and subdomains for communities into communities folder where each community has its own subfolder - Move results back to the main branch, in the resources folder
- Merge weekly workflows into 1 workflow that wil open a PR with the changes - Update other workflows to the new structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new structure is good and I think we can merge this for a start and then check small bits later. But the CI needs a fix for the parallel job, I think.
name: Fetch tool stepwise and merge, fetch tutorials and filter the resources for communities | ||
strategy: | ||
max-parallel: 1 #need to run one after another, since otherwise there is a chance, that mulitple jobs want to push to the results branch at the same time (which fails due to merge) | ||
matrix: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This combined WF triggers a subset job, where each repositories*.list is processed individually. The way it's now combined, everything after the merge part does not really make sense ... and the Fetch list of all available servers
should probably also not be a part of the matrix subset. I would propose to run the Fetch all tool stepwise
in an individual job and store the results as an artifact. Then use the artifact as input for the merge part and have that as another job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adapted the CRON workflow to have 3 jobs
- For getting the available servers and storing the TSV as artifact
- For triggering the subset jobs to fetch tools in parallel and storing the outputs as artifact
- For merging the TSV and running the rest
…ts to share btw jobs
4e72582
to
051460a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI looks good. Lets try it !
runs-on: ubuntu-20.04 | ||
name: Fetch tool stepwise | ||
strategy: | ||
max-parallel: 1 #need to run one after another, since otherwise there is a chance, that mulitple jobs want to push to the results branch at the same time (which fails due to merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this nice new job logic, we can also run all this jobs at the same time.
Co-authored-by: paulzierep <[email protected]>
Fix #164
source
foldermain
branch protected)