Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workflow and assemblies yml files first pass (#206) #207

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NoopDog
Copy link
Collaborator

@NoopDog NoopDog commented Jan 9, 2025

Added files for Assembly (Input) and Workflows matching this evolving schema doc.

workflows:
- trs_id: "https://dockstore.org/api/ga4gh/trs/v2/tools/#workflow/github.com/iwc-workflows/rnaseq-pe/main/versions/v0.9"
type: "REGULATION"
description: "Workflows for the analysis of ChIP-seq, ATAC-Seq, and beyond."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these descriptions for the workflows? or for the 'type' ?

there will eventually be many workflows belonging to a 'type' (or whatever we end up calling it.. type is too vague imo), and i wonder if this source of duplication implies a need for a new yaml file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, reading the descriptions, I agree they should like they describe the workflow type rather than a specific workflow within the type. I think this came from having only one workflow per type for the initial kickoff. Sounds like we do need a type (or "modality?) tab.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could also add (or generate) links to view the workflow details in GitHub, Dockstore etc. or wherever they live.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/should we align these 'types' with the collection as organized on dockstore (and iwc site)? (https://dockstore.org/organizations/iwc)

This can be programmatically fetched if so.

@@ -0,0 +1,15 @@
workflows:
- trs_id: "https://dockstore.org/api/ga4gh/trs/v2/tools/#workflow/github.com/iwc-workflows/rnaseq-pe/main/versions/v0.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the actual trsID here is just #workflow/github.com/iwc-workflows/rnaseq-pe/main, though it does bring up how we want to pin specific versions (or not). Do we want an explicit extra step to update this annotation as new versions are released, or do we want 'latest' @mvdbeek

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooooooooooo. id vote in favor of versions. very good q.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the word 'latest' scared me 😨

- trs_id: "#workflow/github.com/iwc-workflows/generic-variant-calling-wgs-pe/main"
type: "VARIANT_CALLING"
description: "Identify nucleotide polymorphisms and short indels from Illumina and Element data."
ploidy: "any"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is meant for haploid / non-diploid organisms. @nekrut I think you wrote this one ?

description: "Best practices for assembly of prokaryotic and eukaryotic genomes sequenced with a variety of technologies."
ploidy: "any"

# idk yet what makes this specific to bacteria, or if it can be easily generalized
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- trs_id: "#workflow/github.com/iwc-workflows/assembly-with-flye/main"
type: "ASSEMBLY"
description: "Best practices for assembly of prokaryotic and eukaryotic genomes sequenced with a variety of technologies."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is repeated, but also weird ? Maybe stick to the Workflow for ... pattern you've used above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants