Support create/delete project and fix other minor issues. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hryang
commented
Mar 31, 2017
hryang
commented
- Implement the Create/DeleteProject.
- Use v0.6.0 API.
- Add the request id in Error struct
added 4 commits
March 31, 2017 20:02
galaxydi
reviewed
Apr 8, 2017
client.go
Outdated
| Endpoint string // IP or hostname of SLS endpoint | ||
| AccessKeyID string | ||
| AccessKeySecret string | ||
| SessionToken string |
There was a problem hiding this comment.
在 ram 中通常叫做SecurityToken, 参考 https://help.aliyun.com/document_detail/28765.html?spm=5176.doc28756.6.681.wVeuvq
There was a problem hiding this comment.
是参照LogProject里的SessionToken，那我一并改掉吧
galaxydi
reviewed
Apr 8, 2017
log_store.go
Outdated
| } | ||
|
|
||
| uri := fmt.Sprintf("/logstores/%s/index", s.Name) | ||
| println(string(body)) |
galaxydi
reviewed
Apr 8, 2017
log_store.go
Outdated
| return err | ||
| } | ||
|
|
||
| func (s *LogStore) GetIndex() error { |
galaxydi
reviewed
Apr 8, 2017
| Token []string `json:"token"` | ||
| CaseSensitive bool `json:"caseSensitive"` | ||
| IncludeKeys []string `json:"include_keys,omitempty"` | ||
| ExcludeKeys []string `json:"exclude_keys,omitempty"` |
There was a problem hiding this comment.
参考 : ma6174/blog#18
http://gitlab.alibaba-inc.com/serverless/lambda-go-sdk/blob/master/function.go
不确定一定会有问题, 但上述方式更清楚
galaxydi
reviewed
Apr 8, 2017
project_test.go
Outdated
| for i := 0; i < 1; i++ { | ||
| var err error | ||
| name := fmt.Sprintf("faint%d", i) | ||
| //proj, err := c.CreateProject(name, "this is faint") |
galaxydi
reviewed
Apr 8, 2017
project_test.go
Outdated
| if err != nil { | ||
| fmt.Printf("Delete project error: %v\n", err) | ||
| return | ||
| } |
There was a problem hiding this comment.
这个 test 是不打算跑吗? 一个 assert 都没有, xxx_test.go 会被放到 triavis CI 中跑的
There was a problem hiding this comment.
手测的，loghub的project操作有些是异步的，写出reliable的test稍微有点麻烦。我先把测试删了，我现在没有时间加测试
galaxydi
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.