Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #50 jsx files not being linted by the react config #88

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: #50 jsx files not being linted by the react config #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configurations/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const globals = require('globals');

module.exports.recommended = {
files: ['**/*.tsx'],
files: ['**/*.{jsx,tsx}'],
languageOptions: {
globals: {
...globals.browser,
Expand All @@ -18,11 +18,11 @@
'react-hooks': require('eslint-plugin-react-hooks'),
},
rules: {
// TODO broke after upgrading to ESLint v9

Check warning on line 21 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'canonical/sort-react-dependencies': 2,
'react/boolean-prop-naming': 0,
// 'react/button-has-type': 2,
// TODO broke after upgrading to ESLint v9

Check warning on line 25 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/default-props-match-prop-types': 2,
'react/destructuring-assignment': 0,
'react/display-name': 0,
Expand All @@ -31,7 +31,7 @@
'react/forbid-elements': 0,
'react/forbid-foreign-prop-types': 0,
'react/forbid-prop-types': 0,
// TODO broke after upgrading to ESLint v9

Check warning on line 34 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/function-component-definition': [
// 2,
// {
Expand Down Expand Up @@ -96,7 +96,7 @@
prevent: true,
},
],
// TODO broke after upgrading to ESLint v9

Check warning on line 99 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/jsx-no-bind': [
// 2,
// {
Expand All @@ -106,7 +106,7 @@
// },
// ],
'react/jsx-no-comment-textnodes': 2,
// TODO broke after upgrading to ESLint v9

Check warning on line 109 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/jsx-no-constructed-context-values': 2,
'react/jsx-no-duplicate-props': 2,
'react/jsx-no-literals': 0,
Expand Down Expand Up @@ -158,10 +158,10 @@
// 'react/jsx-uses-react': 2,
// 'react/jsx-uses-vars': 2,
'react/jsx-wrap-multilines': 0,
// TODO broke after upgrading to ESLint v9

Check warning on line 161 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/no-access-state-in-setstate': 2,
'react/no-adjacent-inline-elements': 0,
// TODO broke after upgrading to ESLint v9

Check warning on line 164 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/no-array-index-key': 2,
// 'react/no-arrow-function-lifecycle': 2,
// 'react/no-children-prop': 2,
Expand All @@ -170,7 +170,7 @@
'react/no-deprecated': 2,
// 'react/no-did-mount-set-state': 2,
// 'react/no-did-update-set-state': 2,
// TODO broke after upgrading to ESLint v9

Check warning on line 173 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/no-direct-mutation-state': 2,
'react/no-find-dom-node': 2,
'react/no-invalid-html-attribute': 2,
Expand All @@ -179,7 +179,7 @@
// 'react/no-namespace': 2,
'react/no-redundant-should-component-update': 2,
'react/no-render-return-value': 2,
// TODO broke after upgrading to ESLint v9

Check warning on line 182 in configurations/react.js

View workflow job for this annotation

GitHub Actions / Test 

Unexpected 'todo' comment: 'TODO broke after upgrading to ESLint v9'
// 'react/no-set-state': 2,
// 'react/no-string-refs': 2,
// 'react/no-this-in-sfc': 2,
Expand Down
Loading