Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our observability stack we detected that we were emitting the logging twice for the same event and cause. After further investigation and recreating this locally
We can confirm we are double logging. After some investigation it became clear that cobra takes it upon itself to log errors coming out of CLI events it handles. Furthermore, cobra doesn't respect or even know about our log-encoding resulting in this problem. Luckily they provide a flag to suppress these logs.
As such this PR introduces this flag to be true so we don't have to see double logging anymore and can now just see the proper JSON logging we want from
Zap
after the flag is set...
🎩
client-gc-project
command in the makefile to--keep 0
(this will error)make client-gc-project
and see the error being logged twice