change: add a more clear error for duplicate project creation #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePresman
force-pushed
the
change/idempotent-project-create
branch
from
bcecc2d to
9fce6f0
Compare
MikePresman
force-pushed
the
change/idempotent-project-create
branch
from
9fce6f0 to
f61ed37
Compare
MikePresman
changed the title
scott-rc
reviewed
Dec 12, 2023
|
Can you also update the JS |
scott-rc
approved these changes
Dec 13, 2023
js/src/grpc-client.ts
Outdated
Comment on lines
135
to
139
| if (error instanceof RpcError && error.code == "ALREADY_EXISTS") { | ||
| throw new ProjectAlreadyExistsError(`project id ${project} already exists`); | ||
| } else { | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
nit: no need for an else block here
Suggested change
| if (error instanceof RpcError && error.code == "ALREADY_EXISTS") { | |
| throw new ProjectAlreadyExistsError(`project id ${project} already exists`); | |
| } else { | |
| throw error; | |
| } | |
| if (error instanceof RpcError && error.code == "ALREADY_EXISTS") { | |
| throw new ProjectAlreadyExistsError(`project id ${project} already exists`); | |
| } | |
| throw error; |
js/src/utils/errors.ts
Outdated
Comment on lines
2
to
4
| constructor(msg: string) { | ||
| super(msg); | ||
| } |
There was a problem hiding this comment.
nit: no need to re-implement the same constructor
Suggested change
| constructor(msg: string) { | |
| super(msg); | |
| } |
angelini
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a project is attempted to made again the database throws a uniqueness error. This usually comes not so clearly out clientside and as such this change implements a cleaner error message for handling recreating projects that may occur in instances such as job retries with multiple steps.