-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging Overhaul #2308
base: master
Are you sure you want to change the base?
Logging Overhaul #2308
Changes from all commits
add0e0e
279fd76
bb84765
f203965
b9ec1b5
c8175e9
70ba4c0
6fee2fa
9dc1827
a3577fa
c6cf9c3
2d07ad0
831f924
143f91b
e783a2c
4e7e084
28dbcc7
762ebc3
46debda
c6a1fba
2ed86e2
72986f7
d8f98e3
6a8c74e
3b6791d
63cfd1a
4328556
2107c9f
d1ca127
2a1fa71
1ed8a4a
a592be8
a350c1a
04d248c
69ba52d
88611cf
e85d08b
d21a220
bcd6c16
37ee1f3
d834ae1
372c77a
50509b4
470b7f0
9bf6548
fb3e040
e749e10
535a1b8
977c164
2cd4efd
ccedb6c
3967aef
d05b9d7
15ca6ae
6e2f0b5
554077e
b164cf8
d143bff
f677e05
afa24e8
1bf560f
6c29c6f
f45a11d
cf46343
5af549f
3d66d87
fcc6051
8a000eb
4591de7
3705b93
b561524
009e2a1
290c100
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,4 +8,4 @@ local: true | |
# TODO temp | ||
#full_dep: true | ||
#enable_lifetime: true | ||
#stop_on_error: true | ||
#stop_on_error: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,11 @@ | ||
import 'package:frb_example_dart_minimal/src/rust/api/minimal.dart'; | ||
import 'package:frb_example_dart_minimal/src/rust/frb_generated.dart'; | ||
|
||
final LOGGER = FRBLogger.getLogger(); | ||
|
||
// If you are developing a binary program, you may want to put it in `bin/something.dart` | ||
Future<void> main() async { | ||
await RustLib.init(); | ||
print('Call Rust and get: 100+200 = ${await minimalAdder(a: 100, b: 200)}'); | ||
LOGGER.info( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe we can make the LOGGER only used from Rust. If some Dart users want to do logging, just follow the https://pub.dev/packages/logging doc and create another new logger. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I refactored it now so that a user can just do that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (I will check this in the next round review) |
||
'Call Rust and get: 100+200 = ${await minimalAdder(a: 100, b: 200)}'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, maybe we can add a few lines in codegen to sanity check, if we find the string
setup_default_user_utils
, maybe we justlog::warn!("Please migrate to new default user utils, see some_url_link_here for details")
in codegen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be great!