Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import and export command #62

Merged
merged 29 commits into from
Sep 9, 2024
Merged

Conversation

lemonadern
Copy link
Collaborator

@lemonadern lemonadern commented Sep 3, 2024

Close #58

概要

フォーマッタの設定ファイルの内容をワークスペースの設定に反映する import コマンドと、ワークスペースの設定内容をフォーマッタに反映する export コマンドを実装しました

  • import-to-global
    • uroborosqlfmtrc.json の設定を グローバルの settings.json に反映するコマンド
    • .uroborosqlfmtrc.json に存在せず settings.json に存在する設定値は null になる
  • import-to-workspace
    • uroborosqlfmtrc.json の設定を ワークスペースの .vscode/settings.json に反映するコマンド
    • .uroborosqlfmtrc.json に存在せず settings.json に存在する設定値は null になる
  • export
    • settings.json で非nullの設定値を .uroborosqlfmtrc.json に上書きするコマンド
    • settings.json でnullになっている設定値は .uroborosqlfmtrc.json に反映されない

Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: c03c44c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
uroborosql-fmt Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lemonadern lemonadern force-pushed the feat-import-and-export-command branch from 0bd055c to 4734eca Compare September 3, 2024 09:06
package.json Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
@lemonadern lemonadern requested a review from tanzaku September 4, 2024 01:55
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@lemonadern lemonadern requested a review from tanzaku September 4, 2024 07:11
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Requestありがとうございます。いつかコメントを書いたので確認いただけますか?
理解の難しいものは都度相談ください 😉

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
Co-authored-by: Yosuke Ota <[email protected]>
@lemonadern lemonadern requested a review from ota-meshi September 5, 2024 10:04
client/src/command.ts Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
client/src/command.ts Outdated Show resolved Hide resolved
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ota-meshi
Copy link
Member

@tanzaku リクエストが解決したかどうか見ていただけますか?

Copy link
Collaborator

@tanzaku tanzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanzaku
Copy link
Collaborator

tanzaku commented Sep 7, 2024

@ota-meshi 確認してapproveしました

@ota-meshi ota-meshi merged commit f80e2b1 into main Sep 9, 2024
2 checks passed
@ota-meshi ota-meshi deleted the feat-import-and-export-command branch September 9, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

settings.jsonの内容を設定ファイルに同期するコマンドを追加する
3 participants