feat: add support for Ariston Lydos Wifi's boost mode #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address [this issue](fustom/ariston-remotethermo-home-assistant-v3#364) from the Home Assistant integration. I've locally tested this and it works on my device.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address fustom/ariston-remotethermo-home-assistant-v3#364 from the Home Assistant integration.
I've locally tested this and it works on my device. Boost mode is actually a pretty useful mode in my case, and I hated that I was forced to use the app to trigger it. Hopefully this solves the issue.
Disclaimer
I reused the
ariston.const.LuxPlantMode, because it's the same. I don't think it's inherently wrong, but you may not like it.Correct me if I'm wrong, but I presume no particular changes (besides upgrading the dependency) is needed in fustom/ariston-remotethermo-home-assistant-v3 to make this feature appear in Home Assistant.