Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Go version to 1.23 #136

Merged
merged 3 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ linters-settings:
disabled-checks:
- singleCaseSwitch
- ifElseChain
gosec:
excludes:
# G115: Potential integer overflow when converting between integer types
# Excluded due to false positives.
- G115

issues:
exclude-rules:
Expand All @@ -32,9 +37,9 @@ linters:
enable:
- asciicheck
- bodyclose
- copyloopvar
- dupl
- errcheck
- exportloopref
- gocognit
- goconst
- gocritic
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ help: ## Display this help.
##@ Development

.PHONY: generate
generate: generate-deepcopy generate-groups ## Generate Go code.
generate: generate-deepcopy generate-groups fmt ## Generate Go code.

generate-deepcopy: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
$(CONTROLLER_GEN) object:headerFile="$(LICENSE_HEADER_GO)" paths="./..."
Expand Down Expand Up @@ -219,10 +219,10 @@ $(LOCALBIN): ## Ensure that the directory exists

## Tool Versions
KUSTOMIZE_VERSION ?= v4.5.5
CONTROLLER_TOOLS_VERSION ?= v0.8.0
CONTROLLER_TOOLS_VERSION ?= v0.14.0
YQ_VERSION ?= v4.14.1
GOIMPORTS_REVISER_VERSION ?= 32c80678d5d73a50b6966f06b346de58b1d018f1
GOLANGCI_LINT_VERSION ?= v1.55.2
GOLANGCI_LINT_VERSION ?= v1.61.0
LICENSEHEADERCHECKER_VERSION ?= v1.3.0
GORELEASER_VERSION ?= v1.8.2

Expand Down
1 change: 0 additions & 1 deletion apis/config/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions apis/execution/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion config/common/rbac/execution/controller/cluster_role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
creationTimestamp: null
name: controller-role
rules:
- apiGroups:
Expand Down
1 change: 0 additions & 1 deletion config/common/rbac/execution/webhook/cluster_role.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
creationTimestamp: null
name: webhook-role
rules:
- apiGroups:
Expand Down
26 changes: 12 additions & 14 deletions config/common/webhook/execution/manifests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
apiVersion: admissionregistration.k8s.io/v1
kind: MutatingWebhookConfiguration
metadata:
creationTimestamp: null
name: mutating-webhook-configuration
webhooks:
- admissionReviewVersions:
Expand All @@ -11,9 +10,9 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /mutating/jobs.execution.furiko.io
path: /mutating/jobconfigs.execution.furiko.io
failurePolicy: Fail
name: mutating.webhook.jobs.execution.furiko.io
name: mutating.webhook.jobconfigs.execution.furiko.io
rules:
- apiGroups:
- execution.furiko.io
Expand All @@ -23,17 +22,17 @@ webhooks:
- CREATE
- UPDATE
resources:
- jobs
- jobconfigs
sideEffects: None
- admissionReviewVersions:
- v1
clientConfig:
service:
name: webhook-service
namespace: system
path: /mutating/jobconfigs.execution.furiko.io
path: /mutating/jobs.execution.furiko.io
failurePolicy: Fail
name: mutating.webhook.jobconfigs.execution.furiko.io
name: mutating.webhook.jobs.execution.furiko.io
rules:
- apiGroups:
- execution.furiko.io
Expand All @@ -43,13 +42,12 @@ webhooks:
- CREATE
- UPDATE
resources:
- jobconfigs
- jobs
sideEffects: None
---
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
creationTimestamp: null
name: validating-webhook-configuration
webhooks:
- admissionReviewVersions:
Expand All @@ -58,9 +56,9 @@ webhooks:
service:
name: webhook-service
namespace: system
path: /validating/jobs.execution.furiko.io
path: /validating/jobconfigs.execution.furiko.io
failurePolicy: Fail
name: validation.webhook.jobs.execution.furiko.io
name: validation.webhook.jobconfigs.execution.furiko.io
rules:
- apiGroups:
- execution.furiko.io
Expand All @@ -70,17 +68,17 @@ webhooks:
- CREATE
- UPDATE
resources:
- jobs
- jobconfigs
sideEffects: None
- admissionReviewVersions:
- v1
clientConfig:
service:
name: webhook-service
namespace: system
path: /validating/jobconfigs.execution.furiko.io
path: /validating/jobs.execution.furiko.io
failurePolicy: Fail
name: validation.webhook.jobconfigs.execution.furiko.io
name: validation.webhook.jobs.execution.furiko.io
rules:
- apiGroups:
- execution.furiko.io
Expand All @@ -90,5 +88,5 @@ webhooks:
- CREATE
- UPDATE
resources:
- jobconfigs
- jobs
sideEffects: None
Loading
Loading