Update pad.py to include reflective padding #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix documentation to be more accurate around nonspatial arrays
allow None roi/voxel size for spatial arrays
no longer assumes a deformed label will still exist in an array
This is to get around local functions (i.e. the hooks) not being pickle-able which we need for the "spawn" start function (spawn is the default on windows and recent macs)
We want to test with both fork and spawn start methods, but this seems to interfere with the torch tests
|
Can you add tests? |
|
Also please target the patch-1.3.2 branch for your pull request |
numpy is no longer releasing updates for python 3.7, they are on 1.24 but the last release for 3.7 was 1.21. I don't think we need to support it either, but we should test on 3.11
Codecov Report
@@ Coverage Diff @@
## main #195 +/- ##
==========================================
- Coverage 67.60% 67.48% -0.12%
==========================================
Files 98 98
Lines 6829 6844 +15
==========================================
+ Hits 4617 4619 +2
- Misses 2212 2225 +13
|
if using start method = "spawn" and the "start_subprocess" flag for the predict node, we now pass our test.
if using the start method "spawn", and the "spawn_subprocess" flag for the train node, we now pass our test
Now prints the errors in reverse order of execution so the initial pipeline error is printed first
commit 1686b949766b76960534ede1105751591fd91c9f Author: William Patton <[email protected]> Date: Tue Dec 19 08:43:11 2023 -0700 black reformatting commit 26d2c7cfff3f2702f56a5bb4249a0811f54b45ef Author: Mohinta2892 <[email protected]> Date: Thu Nov 2 19:09:15 2023 +0000 Revert "black reformatted" This reverts commit 66dd69b. Only format changed files, since black does not consider formatting history commit a273fd3813fc16b516c2438ad5af0c4ee3f0686b Author: Samia Mohinta <[email protected]> Date: Thu Nov 2 17:12:26 2023 +0000 black reformatted commit bb37769eec33af5921386f283e2579055bb34e6d Author: Samia Mohinta <[email protected]> Date: Thu Nov 2 16:40:32 2023 +0000 add device arg Allow passing cuda device to Predict. Issue #188 commit a3b3588a1406d609ae95370cf2c5339872616011 Author: Samia Mohinta <[email protected]> Date: Thu Nov 2 16:39:09 2023 +0000 add device arg allow passing cuda device to Train
currently failing a few of them, some are expected failures.
parametrized the use of constant or reflect padding. Now avoids using the unittest framework
pattonw
force-pushed
the
reflective_padding
branch
from
d721190
to
531d81d
Compare
|
closing in favor of #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Merge Checklist:
vX.Y-dev)patch-X.Y.Z)This PR adds capability for enabling reflection-padding in
pad.pyhere.