fix: improve vitest rules

fullstacksjs · Jun 8, 2024 · a8127d4 · a8127d4
1 parent 4c52925
commit a8127d4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/modules/fp.js b/src/modules/fp.js
@@ -8,7 +8,6 @@ function fp() {
       'functional/functional-parameters': 'off',
       'functional/no-let': ['error', { allowInForLoopInit: true }],
       'functional/no-loop-statements': 'error',
-      'functional/immutable-data': ['error', { ignoreClasses: true, ignoreImmediateMutation: true, ignoreNonConstDeclarations: true }],
     },
   };
 }

diff --git a/src/modules/typescript.js b/src/modules/typescript.js
@@ -199,7 +199,7 @@ function typescript(options = {}) {
         '@typescript-eslint/no-unnecessary-type-arguments': 'error',
         '@typescript-eslint/no-unnecessary-type-assertion': 'error',
         '@typescript-eslint/no-unsafe-unary-minus': 'error',
-        '@typescript-eslint/no-useless-template-literals': 'warn',
+        'no-unnecessary-template-expression': 'warn',
         '@typescript-eslint/non-nullable-type-assertion-style': 'warn',
         '@typescript-eslint/prefer-includes': 'warn',
         '@typescript-eslint/prefer-optional-chain': 'warn',
@@ -227,6 +227,10 @@ function typescript(options = {}) {
         '@typescript-eslint/switch-exhaustiveness-check': 'error',
         '@typescript-eslint/unbound-method': ['error', { ignoreStatic: true }],
 
+        ...predicate(options.fp, {
+          'functional/immutable-data': ['error', { ignoreClasses: true, ignoreImmediateMutation: true, ignoreNonConstDeclarations: true }],
+        }),
+
         // collisions
         'prefer-promise-reject-errors': 'off',
         'consistent-return': 'off',

diff --git a/src/modules/vitest.js b/src/modules/vitest.js
@@ -58,15 +58,15 @@ function vitest() {
       'vitest/prefer-expect-resolves': 'warn',
       'vitest/prefer-hooks-in-order': 'warn',
       'vitest/prefer-hooks-on-top': 'warn',
-      'vitest/prefer-lowercase-title': 'warn',
+      'vitest/prefer-lowercase-title': 'off',
       'vitest/prefer-mock-promise-shorthand': 'warn',
       'vitest/prefer-snapshot-hint': 'warn',
       'vitest/prefer-spy-on': 'warn',
-      'vitest/prefer-strict-equal': 'warn',
+      'vitest/prefer-strict-equal': 'off',
       'vitest/prefer-to-be': 'warn',
-      'vitest/prefer-to-be-falsy': 'warn',
+      'vitest/prefer-to-be-falsy': 'off',
       'vitest/prefer-to-be-object': 'warn',
-      'vitest/prefer-to-be-truthy': 'warn',
+      'vitest/prefer-to-be-truthy': 'off',
       'vitest/prefer-to-contain': 'warn',
       'vitest/prefer-to-have-length': 'warn',
       'vitest/prefer-todo': 'warn',