Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate ubuntu-latest to ubuntu-24.04 #29

Merged
merged 5 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* @nh13
6 changes: 3 additions & 3 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ name: Python package

on: [push]
env:
POETRY_VERSION: 1.0
POETRY_VERSION: 1.8.3

jobs:
testing:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment: github-actions-ci
strategy:
matrix:
PYTHON_VERSION: [3.8]
PYTHON_VERSION: [3.9]
steps:
- uses: actions/checkout@v2

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

`pip install pyfgaws`

**Requires python 3.8**
**Requires python 3.9**

# Getting Setup

Expand Down
4 changes: 2 additions & 2 deletions conda-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Setup python version and poetry
python=3.8.2
poetry=1.0.5
python=3.9
poetry=1.8.3
1,550 changes: 920 additions & 630 deletions poetry.lock

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions pyfgaws/batch/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
from mypy_boto3_batch.type_defs import KeyValuePairTypeDef # noqa
from mypy_boto3_batch.type_defs import NodeOverridesTypeDef # noqa
from mypy_boto3_batch.type_defs import ResourceRequirementTypeDef # noqa
from mypy_boto3_batch.type_defs import RetryStrategyTypeDef # noqa
from mypy_boto3_batch.type_defs import RetryStrategyOutputTypeDef # noqa
from mypy_boto3_batch.type_defs import SubmitJobResponseTypeDef # noqa

from pyfgaws.core import MINIMUM_DELAY
Expand Down Expand Up @@ -149,7 +149,7 @@ def __init__(
parameters: Optional[Dict[str, str]] = None,
container_overrides: Optional[ContainerOverridesTypeDef] = None,
node_overrides: Optional[NodeOverridesTypeDef] = None,
retry_strategy: Optional[RetryStrategyTypeDef] = None,
retry_strategy: Optional[RetryStrategyOutputTypeDef] = None,
timeout: Optional[JobTimeoutTypeDef] = None,
logger: Optional[logging.Logger] = None,
) -> None:
Expand Down Expand Up @@ -181,7 +181,7 @@ def __init__(
container_overrides
)
self.node_overrides: Optional[NodeOverridesTypeDef] = node_overrides
self.retry_strategy: Optional[RetryStrategyTypeDef] = retry_strategy
self.retry_strategy: Optional[RetryStrategyOutputTypeDef] = retry_strategy
self.timeout: Optional[JobTimeoutTypeDef] = timeout

# Add to container overrides
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ include = [


[tool.poetry.dependencies]
python = "^3.8"
python = "^3.9"
attrs = "^19.3.0"
defopt = "^6.0"
boto3 = "^1.13.18"
Expand All @@ -37,7 +37,7 @@ fgpyo = "^0.0.6"

[tool.poetry.dev-dependencies]
pytest = "^5.4.2"
mypy = "^0.770"
mypy = ">=1.7.0"
flake8 = "^3.8.1"
black = "^23.1.0"
pytest-cov = ">=2.8.1"
Expand Down
Loading