[feature] support signal handling in AWS batch #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the `run-job` tool cancel or terminate the job after submission. The batch API now also supports the above during job creation.
nh13
commented
Jun 18, 2020
| for code in self.terminate_on: | ||
| signal.signal( | ||
| code, lambda signum, frame: self.terminate_job(reason=f"Interrupted: {code}") | ||
| ) |
There was a problem hiding this comment.
this needs a unit test probably. Make a sub-process, then check that it terminates?
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
========================================
- Coverage 77.4% 75.9% -1.6%
========================================
Files 11 11
Lines 439 453 +14
Branches 45 51 +6
========================================
+ Hits 340 344 +4
- Misses 88 96 +8
- Partials 11 13 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the
run-jobtool cancel or terminate the job after submission.The batch API now also supports the above during job creation.