Skip to content

Commit

Permalink
ci: fix download collision issue with cibuildwheen
Browse files Browse the repository at this point in the history
The cibuildwheel for macos for both arm64 and x86_64 create wheel
artifacts named the same (e.g. pybwa-1.0.3-cp311-cp311-macosx_14_0_arm64.whl).
The upload/artifact step then uses the correct name when it uploads, but
it zips it up first, so when you unzip the macos artifacts for the two
architecture, they'll have the same name.

See: https://cibuildwheel.pypa.io/en/stable/faq/#macos-building-cpython-38-wheels-on-arm64
See: pypa/cibuildwheel#2080
  • Loading branch information
nh13 committed Jan 17, 2025
1 parent 643e98a commit 7e374f7
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,14 @@ jobs:
with:
submodules: "true"

- uses: actions/setup-python@v5
if: runner.os != 'macOS' || runner.arch != 'ARM64'

# See: https://cibuildwheel.pypa.io/en/stable/faq/#macos-building-cpython-38-wheels-on-arm64
- uses: actions/setup-python@v5
with:
python-version: 3.8
if: runner.os == 'macOS' && runner.arch == 'ARM64'

- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.15.0
Expand Down

0 comments on commit 7e374f7

Please sign in to comment.