Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line tool to produce and print pairwise alignments. #739

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tfenne
Copy link
Member

@tfenne tfenne commented Nov 11, 2021

This is here mostly to review Alignment.revcomped and the associated tests. You're welcome to review the personal tool as well, but I may or may not take feedback there ;)

@tfenne tfenne self-assigned this Nov 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Base: 95.66% // Head: 95.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (2be4171) compared to base (da9ecbc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files         125      125           
  Lines        7239     7247    +8     
  Branches      507      504    -3     
=======================================
+ Hits         6925     6933    +8     
  Misses        314      314           
Flag Coverage Δ
unittests 95.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cala/com/fulcrumgenomics/alignment/Alignment.scala 98.82% <100.00%> (+0.05%) ⬆️
...fulcrumgenomics/umi/ConsensusCallingIterator.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tfenne tfenne marked this pull request as ready for review November 11, 2021 21:29
@tfenne tfenne requested review from nh13 and sstadick November 11, 2021 21:29
) extends FgBioTool {

override def execute(): Unit = {
val aligner = Aligner(1, -4, -6, -1, mode)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scoring params are hard-coded. Nice to have them exposed on the command line.


println()
println("Right Aligned:")
right.paddedString().foreach(println)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have the alignment score, cigar, target start/end, query start/end printed too. The latter are useful for local and glocal.

@tfenne
Copy link
Member Author

tfenne commented Dec 21, 2021

@nh13 I don't disagree with you suggestions but don't have time to act on them. Shall we merge and can add those later if/when we want?

@tfenne tfenne force-pushed the tf_pairwise_align branch from 0946a5a to 50b51a8 Compare April 26, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants