Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a cached aligner #1022

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: create a cached aligner #1022

wants to merge 5 commits into from

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Jan 16, 2025

This avoids re-allocating the matrix every time

This avoids re-allocating the matrix every time
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 17:58 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 17:59 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 17:59 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 18:00 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 18:00 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 18:01 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 18:01 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions January 16, 2025 18:06 — with GitHub Actions Inactive
@nh13 nh13 deployed to github-actions January 16, 2025 18:06 — with GitHub Actions Active
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.59%. Comparing base (c4e4bb6) to head (a44f400).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/com/fulcrumgenomics/alignment/Aligner.scala 70.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   95.62%   95.59%   -0.03%     
==========================================
  Files         126      126              
  Lines        7378     7722     +344     
  Branches      490      501      +11     
==========================================
+ Hits         7055     7382     +327     
- Misses        323      340      +17     
Flag Coverage Δ
unittests 95.59% <70.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant