Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add system test to github workflow for all distributions. #32

Merged
merged 2 commits into from
Dec 22, 2024

Conversation

fujitatomoya
Copy link
Owner

closes #31

@fujitatomoya fujitatomoya force-pushed the add-system-test-workflow branch from a66e7bb to e1ed439 Compare December 22, 2024 21:31
source /opt/ros/${ROS_DISTRO}/setup.bash
cd ${COLCON_WORKSPACE}

# TODO(@fujitatomoya): currently unit tests are missing for parameter server with `colcon test`.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unit tests for parameter server interfaces and APIs, handled with #18

Comment on lines -31 to -32
launch.actions.ExecuteProcess(
cmd = ['ros2', 'run', 'ros2_persistent_parameter_server_test', 'client']
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since i am not sure how to get the return code from this specific command via launch action, remove this test command from here. instead, having it in the python script to call the command via subprocess to check the return code to tell the test is failed or not to github workflow.

@fujitatomoya fujitatomoya merged commit 4b5d89b into rolling Dec 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add system test to github workflow for all distros
1 participant