Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] add unit and system test via ament_add_gtest #18

Open
fujitatomoya opened this issue Jan 3, 2024 · 0 comments
Open

[FR] add unit and system test via ament_add_gtest #18

fujitatomoya opened this issue Jan 3, 2024 · 0 comments

Comments

@fujitatomoya
Copy link
Owner

Feature request

Feature description

Currently test needs to be started by manual procedure with different executable package named ros2_persistent_parameter_server_test.
The CI/CD test should be integrated into parameter_server package with ament_add_gtest, so that it can be tested with colcon test command for integration aligned with other ROS 2 packages.

Implementation considerations

  • add test folder into parameter_server package with ament_add_gtest.
  • move test contents from ros2_persistent_parameter_server_test to the test folder described above.
  • all uncrustify warnings and coding style needs to be addressed.
  • add colcon test --packages-select parameter_server in github workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant