Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed String.startsWith !FABLE_COMPILER condition #611

Merged

Conversation

laurentpayot
Copy link
Contributor

Hi, I had an error with String.endsWith when compiling a project using FSharpPlus with Fable. String.endsWith was not surrounded by a !FABLE_COMPILER symbol condition.
A Fable maintainer fixed my issue by making String.endsWith work with Fable, as well as String.startsWith.

This PR simply removes the !FABLE_COMPILER symbol condition around String.startsWith that is not needed anymore.

@wallymathieu
Copy link
Member

Do we need to update fable as well?

@laurentpayot
Copy link
Contributor Author

laurentpayot commented Oct 30, 2024

@wallymathieu Oopsie. Yes, I just bumped Fable to version 4.23.0 so the fix is included.

@cannorin cannorin merged commit db45914 into fsprojects:master Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants