Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NonEmptyList and NonEmptySeq Helper Functions #610

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Add NonEmptyList and NonEmptySeq Helper Functions #610

merged 6 commits into from
Nov 4, 2024

Conversation

devinlyons
Copy link
Contributor

This PR adds helper functions to the NonEmptyList and NonEmptySeq modules that bring them up to feature parity with the List and Seq modules.

@wallymathieu
Copy link
Member

Perhaps the doc-xml is either malformed or requires an update of fsdocs

  System.Xml.XmlException: The 'c' start tag on line 5987 position 77 does not match the end tag of 'summary'. Line 5987, position 143.

From https://github.com/fsprojects/FSharpPlus/actions/runs/11390820294/job/31734854875?pr=610

@devinlyons devinlyons force-pushed the add-collection-helper-functions branch from 6504ecf to 24ca92d Compare October 21, 2024 18:57
@cannorin cannorin requested a review from gusty November 3, 2024 09:32
gusty
gusty approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@gusty gusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @devinlyons and excellent review by @cannorin

If you want to do more PRs like this, I have somewhere a small lists of collection missing functions from similar collections.

@cannorin cannorin merged commit 9c203e7 into fsprojects:master Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusty gusty gusty approved these changes

@cannorin cannorin Awaiting requested review from cannorin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devinlyons @wallymathieu @gusty @cannorin