Changes for 0.12.0 release #70
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |
| "isRoot": true, | ||
| "tools": { | ||
| "paket": { | ||
| "version": "8.0.0", | ||
| "commands": [ | ||
| "paket" | ||
| ] | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "8.0.100", | ||
| "rollForward": "latestMajor" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,20 @@ | ||
| source https://api.nuget.org/v3/index.json | ||
|
|
||
| storage: none | ||
| framework: net80, netstandard20, netstandard21 | ||
|
|
||
| nuget Unquote ~> 6.1.0 | ||
| nuget FSharp.Core >= 4.7.2 lowest_matching: true | ||
|
|
||
| nuget AWSSDK.DynamoDBv2 ~> 3.7.5 | ||
| nuget DotNet.ReproducibleBuilds | ||
| github eiriktsarpalis/TypeShape:10.0.0 src/TypeShape/TypeShape.fs | ||
|
|
||
| group Test | ||
| source https://api.nuget.org/v3/index.json | ||
| framework: net80 | ||
|
|
||
| nuget FsCheck | ||
| nuget Microsoft.NET.Test.Sdk | ||
| nuget xunit | ||
| nuget xunit.runner.visualstudio |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,80 @@ | ||
| STORAGE: NONE | ||
| RESTRICTION: || (== net8.0) (== netstandard2.0) (== netstandard2.1) | ||
| NUGET | ||
| remote: https://api.nuget.org/v3/index.json | ||
| AWSSDK.Core (3.7.300.11) | ||
| Microsoft.Bcl.AsyncInterfaces (>= 1.1) - restriction: || (&& (== net8.0) (< netcoreapp3.1)) (== netstandard2.0) (== netstandard2.1) | ||
| AWSSDK.DynamoDBv2 (3.7.300.11) | ||
| AWSSDK.Core (>= 3.7.300.11 < 4.0) | ||
| DotNet.ReproducibleBuilds (1.1.1) | ||
| Microsoft.SourceLink.AzureRepos.Git (>= 1.1.1) | ||
| Microsoft.SourceLink.Bitbucket.Git (>= 1.1.1) | ||
| Microsoft.SourceLink.GitHub (>= 1.1.1) | ||
| Microsoft.SourceLink.GitLab (>= 1.1.1) | ||
| FSharp.Core (4.7.2) | ||
| Microsoft.Bcl.AsyncInterfaces (8.0) - restriction: || (&& (== net8.0) (< netcoreapp3.1)) (== netstandard2.0) (== netstandard2.1) | ||
| System.Threading.Tasks.Extensions (>= 4.5.4) - restriction: || (&& (== net8.0) (>= net462)) (&& (== net8.0) (< netstandard2.1)) (== netstandard2.0) (&& (== netstandard2.1) (>= net462)) | ||
| Microsoft.Build.Tasks.Git (8.0) | ||
| Microsoft.SourceLink.AzureRepos.Git (8.0) | ||
| Microsoft.Build.Tasks.Git (>= 8.0) | ||
| Microsoft.SourceLink.Common (>= 8.0) | ||
| Microsoft.SourceLink.Bitbucket.Git (8.0) | ||
| Microsoft.Build.Tasks.Git (>= 8.0) | ||
| Microsoft.SourceLink.Common (>= 8.0) | ||
| Microsoft.SourceLink.Common (8.0) | ||
| Microsoft.SourceLink.GitHub (8.0) | ||
| Microsoft.Build.Tasks.Git (>= 8.0) | ||
| Microsoft.SourceLink.Common (>= 8.0) | ||
| Microsoft.SourceLink.GitLab (8.0) | ||
| Microsoft.Build.Tasks.Git (>= 8.0) | ||
| Microsoft.SourceLink.Common (>= 8.0) | ||
| System.Runtime.CompilerServices.Unsafe (6.0) - restriction: || (&& (== net8.0) (>= net461)) (&& (== net8.0) (>= net462)) (&& (== net8.0) (< netcoreapp2.1) (< netstandard2.1)) (&& (== net8.0) (< netstandard1.0)) (&& (== net8.0) (< netstandard2.0)) (&& (== net8.0) (>= wp8)) (== netstandard2.0) (&& (== netstandard2.1) (>= net462)) | ||
| System.Threading.Tasks.Extensions (4.5.4) - restriction: || (&& (== net8.0) (>= net462)) (&& (== net8.0) (< netstandard2.1)) (== netstandard2.0) (&& (== netstandard2.1) (>= net462)) | ||
| System.Runtime.CompilerServices.Unsafe (>= 4.5.3) - restriction: || (&& (== net8.0) (>= net461)) (&& (== net8.0) (< netcoreapp2.1)) (&& (== net8.0) (< netstandard1.0)) (&& (== net8.0) (< netstandard2.0)) (&& (== net8.0) (>= wp8)) (== netstandard2.0) (== netstandard2.1) | ||
| Unquote (6.1) | ||
| FSharp.Core (>= 4.7.2) | ||
| GITHUB | ||
| remote: eiriktsarpalis/TypeShape | ||
| src/TypeShape/TypeShape.fs (6e7fe07c799de723de7e4b32d64a4fd6c1697c7f) | ||
| GROUP Test | ||
| RESTRICTION: == net8.0 | ||
| NUGET | ||
| remote: https://api.nuget.org/v3/index.json | ||
| FsCheck (2.16.6) | ||
| FSharp.Core (>= 4.2.3) | ||
| FSharp.Core (8.0.100) | ||
| Microsoft.CodeCoverage (17.8) | ||
| Microsoft.NET.Test.Sdk (17.8) | ||
| Microsoft.CodeCoverage (>= 17.8) | ||
| Microsoft.TestPlatform.TestHost (>= 17.8) | ||
| Microsoft.NETCore.Platforms (7.0.4) | ||
| Microsoft.TestPlatform.ObjectModel (17.8) | ||
| NuGet.Frameworks (>= 6.5) | ||
| System.Reflection.Metadata (>= 1.6) | ||
| Microsoft.TestPlatform.TestHost (17.8) | ||
| Microsoft.TestPlatform.ObjectModel (>= 17.8) | ||
| Newtonsoft.Json (>= 13.0.1) | ||
| NETStandard.Library (2.0.3) | ||
| Microsoft.NETCore.Platforms (>= 1.1) | ||
| Newtonsoft.Json (13.0.3) | ||
| NuGet.Frameworks (6.8) | ||
| System.Collections.Immutable (8.0) | ||
| System.Reflection.Metadata (8.0) | ||
| System.Collections.Immutable (>= 8.0) | ||
| xunit (2.6.2) | ||
| xunit.analyzers (>= 1.6) | ||
| xunit.assert (>= 2.6.2) | ||
| xunit.core (2.6.2) | ||
| xunit.abstractions (2.0.3) | ||
| xunit.analyzers (1.6) | ||
| xunit.assert (2.6.2) | ||
| xunit.core (2.6.2) | ||
| xunit.extensibility.core (2.6.2) | ||
| xunit.extensibility.execution (2.6.2) | ||
| xunit.extensibility.core (2.6.2) | ||
| NETStandard.Library (>= 1.6.1) | ||
| xunit.abstractions (>= 2.0.3) | ||
| xunit.extensibility.execution (2.6.2) | ||
| NETStandard.Library (>= 1.6.1) | ||
| xunit.extensibility.core (2.6.2) | ||
| xunit.runner.visualstudio (2.5.4) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,9 +62,6 @@ module CondExprTypes = | |
| Map : Map<string, int64> | ||
|
|
||
| Set : Set<int64> | ||
| } | ||
|
|
||
| type ``Conditional Expression Tests`` (fixture : TableFixture) = | ||
|
|
@@ -85,7 +82,6 @@ type ``Conditional Expression Tests`` (fixture : TableFixture) = | |
| List = [for _ in 0L .. rand() % 5L -> rand() ] | ||
| Array = [| for _ in 0L .. rand() % 5L -> rand() |] | ||
| Union = if rand() % 2L = 0L then UA (rand()) else UB(guid()) | ||
| } | ||
|
|
||
| let table = fixture.CreateEmpty<CondExprRecord>() | ||
|
|
@@ -104,6 +100,14 @@ type ``Conditional Expression Tests`` (fixture : TableFixture) = | |
| fun () -> table.PutItem(item, precondition = itemDoesNotExist) | ||
| |> shouldFailwith<_, ConditionalCheckFailedException> | ||
|
|
||
| let [<Fact(Skip = "Not sure if this should be working")>] ``Item not exists failure should add conflicting item data to the exception`` () = | ||
|
There was a problem hiding this comment. this looks reasonable to me - don't have a prod env to hand so I guess that points the finget of blame at the simulators... |
||
| let item = mkItem() | ||
| let _key = table.PutItem(item, precondition = itemDoesNotExist) | ||
| try | ||
| table.PutItem(item, precondition = itemDoesNotExist) |> ignore | ||
|
There was a problem hiding this comment. @samritchie Hm, probably should assert that it does not just succeed |
||
| with :? ConditionalCheckFailedException as e -> | ||
| test <@ e.Item.Count > 0 @> | ||
|
|
||
| let [<Fact>] ``String precondition`` () = | ||
| let item = mkItem() | ||
| let _key = table.PutItem item | ||
|
|
@@ -376,13 +380,6 @@ type ``Conditional Expression Tests`` (fixture : TableFixture) = | |
| fun () -> table.Template.PrecomputeConditionalExpr <@ fun r -> r.Bytes.Length = r.Bytes.Length @> | ||
| |> shouldFailwith<_, ArgumentException> | ||
|
|
||
| let [<Fact>] ``EXISTS precondition`` () = | ||
| let item = { mkItem() with List = [1L] } | ||
| let _key = table.PutItem item | ||
|
|
@@ -466,7 +463,6 @@ type ``Conditional Expression Tests`` (fixture : TableFixture) = | |
| test false <@ fun r -> r.Map > Map.empty @> | ||
| test false <@ fun r -> r.Set > Set.empty @> | ||
| test false <@ fun r -> r.Ref > ref "12" @> | ||
| test false <@ fun r -> r.Tuple <= (1L, 2L) @> | ||
| test false <@ fun r -> r.Nested <= r.Nested @> | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A .12 might not be unreasonable as there are new supported expression features (and a removal of an obsoletion)