Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader speedboost #81

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Reader speedboost #81

merged 4 commits into from
Jan 24, 2024

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Jan 24, 2024

  • make RescanRows speed linear

Before, the speed of RescanRows was approximately quadratic with regards to the amount of rows. Now it is approximately linear. Read in of XLSX file with 150000 lines was increased from 15 minutes on my machine to 2 seconds.

Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add performance unit tests
  • add comment to skip flag

Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the same performance test for exceljs please 😅

@Freymaurer Freymaurer merged commit 8b8c080 into main Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants