bzip2: fix bug with duplicate read of CRC32 when it overlaps end of buffer and 'bzip2-done is thrown. #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is quite rare and usually manifests only on large bzip2 files (several 100s of Megabytes in size). For instance, it can be reproduced while processing this part of wikipedia dump with the following simple script:
At block 383 the
invalid-bzip2-data
error will be signalled.We also had a conversation about the same bug some time ago in the issues (which are not accessible now, unfortunately).