Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close the jline terminal at the end (#7) #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gnodet
Copy link

@gnodet gnodet commented Jan 24, 2023

Possible fix for #7

@gnodet gnodet changed the title Properly close the jline terminal at the end Properly close the jline terminal at the end (#7) Jan 24, 2023
@frossm
Copy link
Owner

frossm commented Jan 24, 2023

Oh no! Stupid user error? I'll take a look at your changes and give it a test. Thank you very much.

@frossm
Copy link
Owner

frossm commented Jan 24, 2023

The change you made to main didn't seem to help. When I compile with jline-reader v3.22 there are no errors and the product seems to run fine. But after I exit rpncalc , many of the keys do not work as they normally would (and they way they worked under v3.21.0).

Up arrow gives: [A
Down arrow shows: [B
Right arrow: [C
Left arrow: [D
Home Key: [H
Etc....

I do think it's probably a cleanup issue since everything seems to work within the program. I did not receive an exception after the program was run.

You've defined the reader differently than I did and I'll have to look into that. I'm certainly a novice with jline3. Please let me know if you have any other ideas. Certainly seems like a windows issue.

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants