Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.17.1 #1676

Merged
merged 1 commit into from
Sep 2, 2024
Merged

v5.17.1 #1676

merged 1 commit into from
Sep 2, 2024

Conversation

pierrecamilleri
Copy link
Collaborator

  • fix: deprecated dependencies (PR 1674)
  • fix: unexpected "missing-label" error with option header_case = False (#1635)
  • fix: KeyError when a "primaryKey" is missing (#1633)
  • fix: unexpected field-error for a boolean "example" with "trueValues" or
    "falseValues" properties (#1610)

@pierrecamilleri
Copy link
Collaborator Author

@pdelboca @roll

In the process of releasing the bug fixes in a patch version I've got a "not allowed to push to main error", but the tag has been pushed nonetheless, ending in a somewhat inconsistent state where the Changelog and settings.py are not up to sync on the main branch.

This PR corrects the situation, but I am not able to merge it by myself (not able to review my own changes). I'd like to take this opportunity to ask you how you intend to proceed with such reviews (do I request one of you as reviewer ?). Thanks !

@pdelboca pdelboca self-requested a review September 2, 2024 07:33
@pdelboca
Copy link
Contributor

pdelboca commented Sep 2, 2024

Hello @pierrecamilleri ! Approved!

For now I guess that just adding @roll and me as reviewers will work. We should be able to help in a timely manner.

If we feel we are getting stuck, we can change the rules and allow maintainers to merge without explicit approvals. (A workflow I am a fan off since I rather let other maintainers do and not get blocked, and later review and change if required.)

@pierrecamilleri pierrecamilleri merged commit bc67dee into main Sep 2, 2024
18 checks passed
@pierrecamilleri pierrecamilleri deleted the release-v5.17.1 branch September 2, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants